Enforce image safety during image_conversion#12
Open
JohnGarbutt wants to merge 1 commit intostackhpc/ussurifrom
Open
Enforce image safety during image_conversion#12JohnGarbutt wants to merge 1 commit intostackhpc/ussurifrom
JohnGarbutt wants to merge 1 commit intostackhpc/ussurifrom
Conversation
This does two things: 1. It makes us check that the QCOW backing_file is unset on those types of images. Nova and Cinder do this already to prevent an arbitrary (and trivial to accomplish) host file exposure exploit. 2. It makes us restrict VMDK files to only allowed subtypes. These files can name arbitrary files on disk as extents, providing the same sort of attack. Default that list to just the types we believe are actually useful for openstack, and which are monolithic. The configuration option to specify allowed subtypes is added in glance's config and not in the import options so that we can extend this check later to image ingest. The format_inspector can tell us what the type and subtype is, and we could reject those images early and even in the case where image_conversion is not enabled. Closes-Bug: #1996188 Change-Id: Idf561f6306cebf756c787d8eefdc452ce44bd5e0 (cherry picked from commit 0d6282a) (cherry picked from commit 4967ab6) (cherry picked from commit dc8e5a5) (cherry picked from commit f45b5f0) (cherry picked from commit 9a98c4a) Conflicts: glance/tests/unit/async_/flows/plugins/test_image_conversion.py - removed code related to missing tests - 050802d (cherry picked from commit 06e6be5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does two things:
The configuration option to specify allowed subtypes is added in glance's config and not in the import options so that we can extend this check later to image ingest. The format_inspector can tell us what the type and subtype is, and we could reject those images early and even in the case where image_conversion is not enabled.
Closes-Bug: #1996188
Change-Id: Idf561f6306cebf756c787d8eefdc452ce44bd5e0 (cherry picked from commit 0d6282a) (cherry picked from commit 4967ab6) (cherry picked from commit dc8e5a5) (cherry picked from commit f45b5f0) (cherry picked from commit 9a98c4a) Conflicts: glance/tests/unit/async_/flows/plugins/test_image_conversion.py